Include test scenario scripts in timer_enabled template #10947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 3d830ea and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
[jcerny@fedora scap-security-guide{pr/10947}]$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --dontclean timer_dnf-automatic_enabled
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2023-08-07-1152/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_timer_dnf-automatic_enabled
INFO - Script timer_enabled.pass.sh using profile (all) OK
INFO - Script timer_disabled.fail.sh using profile (all) OK
[jcerny@fedora scap-security-guide{pr/10947}]$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --remediate-using ansible --dontclean timer_dnf-automatic_enabled
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2023-08-07-1333/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_timer_dnf-automatic_enabled
INFO - Script timer_disabled.fail.sh using profile (all) OK
INFO - Script timer_enabled.pass.sh using profile (all) OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This template is currently used by only two rules but didn't have test scenario scripts.
This PR introduces test scenarios scripts and removes similar tests from
timer_dnf-automatic_enabledrule.Rationale:
Easier to test changes in existing rules using this template.
Also easier to test eventual new rules which adopts this template.
Review Hints:
The CI tests for CS8 will probably fail with
timer_logrotate_enabledrule and this is expected sincerhel8is not defined inprodtype.