Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_machine_only_rules: allow multiple blank characters #10983

Merged

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • modify regex which checks for presence of machine platform conditional in Ansible remediations - allow multiple blank chars between items of a list

Rationale:

Review Hints:

  1. ./build_product ol8
  2. cd build
  3. ctest -R machine-only-rules --output-on-failure

@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. Test Suite Update in Test Suite. labels Aug 11, 2023
@vojtapolasek vojtapolasek added this to the 0.1.70 milestone Aug 11, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt requested a review from a team August 11, 2023 10:03
@codeclimate
Copy link

codeclimate bot commented Aug 11, 2023

Code Climate has analyzed commit 574cde1 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added bugfix Fixes to reported bugs. and removed bugfix Fixes to reported bugs. labels Aug 16, 2023
@marcusburghardt marcusburghardt self-assigned this Aug 16, 2023
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fix the error when the platform receive more arguments and the line is wrapped. Thanks for the fix.

@marcusburghardt
Copy link
Member

codeclimate alert can be waived. It is not detecting the line continuation. Other failed tests are known issues not related to this PR.

@marcusburghardt marcusburghardt merged commit a20d55c into ComplianceAsCode:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. Test Suite Update in Test Suite.
Projects
None yet
2 participants