-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple STIG id table generation #11016
Fix multiple STIG id table generation #11016
Conversation
Despite this STIG id is only applicable to RHEL<8.2. The rule does both configurations that are applicable to RHEL<8.2 and RHEL>=8.2. So it makes sense to keep both STIG ids here.
This rule accounts covers both STIG ids assigned. The remediation apparently only fixes el>=8.2 but the check accounts for password-auth and faillock.conf files.
This STIG id is also covered by this rule and there is no need to restrict the platform since it covers both scenarios for el<8.2 and el>=8.2.
This rule covers both scenarios for el<8.2 and el>=8.2.
This rule covers both scenarios for password-auth and system-auth file.
Code Climate has analyzed commit c18174a and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thank you @ggbecker . I went through all rules and changes seem to be appropriate.
I checked the output table and it seems that it now works as expected based on the PR description.
The code climate warning is valid, but I don't think it falls into scope of this PR.
The Rawhide Automatus is currently broken.
Merging.
Description:
Rationale:
Review Hints: