Add ansible remediation for UBTU-20-010075

[dexterle]

Description:

• Fix UBTU-20-010075
• Add Ansible remediation for accounts_passwords_pam_faildelay_delay

Rationale:

• Part of Ubuntu 20.04 DISA STIG v1r9 profile upgrade
• Ubuntu2004 stig profile v1r9 update #10738

Review Hints:

Build the product:

./build_product ubuntu2004

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2004-playbook-stig.yml --tags "DISA-STIG-UBTU-20-010075"

Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.

git checkout dexterle:add-manual-stig-ubtu-20-v1r9

This STIG can be tested with the latest Ubuntu 2004 Benchmark SCAP. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/

[openshift-ci]

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[teacup-on-rockingchair]

Nice improvement 🙇 have nothing to add besides @marcusburghardt note

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

New datastream is missing ansible remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_passwords_pam_faildelay_delay'.

[codeclimate]

Code Climate has analyzed commit 6fd98ca and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

[dodys]

/retest

[dodys]

@dexterle I wonder if we can change this PR to instead use the bash and ansible remediation from the template. Those were added after both Ubuntu's and Suse's remediation already existed. It might be the time to consolidate everything into the template.
@teacup-on-rockingchair if you could also test using the template remediation on your side ^
I will share my results later

[dodys]

@dexterle I wonder if we can change this PR to instead use the bash and ansible remediation from the template. Those were added after both Ubuntu's and Suse's remediation already existed. It might be the time to consolidate everything into the template. @teacup-on-rockingchair if you could also test using the template remediation on your side ^ I will share my results later

The template seems enough and the tests are still passing

[teacup-on-rockingchair]

@dexterle I wonder if we can change this PR to instead use the bash and ansible remediation from the template. Those were added after both Ubuntu's and Suse's remediation already existed. It might be the time to consolidate everything into the template. @teacup-on-rockingchair if you could also test using the template remediation on your side ^ I will share my results later

The template seems enough and the tests are still passing

@dexterle I wonder if we can change this PR to instead use the bash and ansible remediation from the template. Those were added after both Ubuntu's and Suse's remediation already existed. It might be the time to consolidate everything into the template. @teacup-on-rockingchair if you could also test using the template remediation on your side ^ I will share my results later

Works ok on my setup for SLES 👍

[openshift-ci]

@dexterle: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.16-images	6fd98ca	link	true	/test 4.16-images
ci/prow/4.12-images	6fd98ca	link	true	/test 4.12-images
ci/prow/4.17-images	6fd98ca	link	true	/test 4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jan-cerny]

ping

[dodys]

dexterle reached out last week about continuing work on this PRs, and I've asked to open new ones for a clean state. Therefore closing this one.