Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UBTU-20-010045 for enforcing proper kex exchange algorithms #11072

Closed

Conversation

dexterle
Copy link
Contributor

@dexterle dexterle commented Sep 7, 2023

Description:

  • Fix UBTU-20-010045
  • Add test for ensuring proper kex exchange algorithms

Rationale:

Review Hints:

Build the product:

./build_product ubuntu2004

Run a test with the build:

cd build/test
ctest -R quick

This commit will add UBTU-20-010045 for sshd_use_approved_kex_ordered_stig rule. Additionally, ubuntu2004 has been included in the tests
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Used by openshift-ci bot. needs-ok-to-test Used by openshift-ci bot. labels Sep 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 7, 2023

Code Climate has analyzed commit 7dd492c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Sep 8, 2023
@marcusburghardt marcusburghardt requested a review from a team September 8, 2023 07:29
@marcusburghardt marcusburghardt added this to the 0.1.70 milestone Sep 8, 2023
@dodys dodys self-assigned this Sep 8, 2023
@dexterle dexterle marked this pull request as ready for review September 11, 2023 14:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 11, 2023
@dodys
Copy link
Contributor

dodys commented Sep 13, 2023

I'm closing this PR in favor of PR #11053 where I've included your commit.

@dodys dodys closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants