Fix Automatus traceback #11111
Merged
Fix Automatus traceback #11111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tries to fix a traceback that happens when evaluating
a SLE15 data stream on a container back end when the test scenarios
require to install a package into the back end.
Resolves:
```
[jcerny@fedora scap-security-guide{master}]$ tests/test_rule_in_container.sh --no-remove-machine-only --dontclean --logdir logs_bash --remediate-using bash --name ssg_test_suite --datastream build/ssg-sle15-ds.xml audit_rules_login_events
Setting console output to log level INFO
INFO - The base image option has been specified, choosing Podman-based test environment.
INFO - Logging into logs_bash-4/test_suite.log
WARNING - Nothing has been tested!
Traceback (most recent call last):
File "/home/jcerny/work/git/scap-security-guide/tests/automatus.py", line 511, in <module>
main()
File "/home/jcerny/work/git/scap-security-guide/tests/automatus.py", line 507, in main
options.func(options)
File "/home/jcerny/work/git/scap-security-guide/tests/ssg_test_suite/rule.py", line 689, in perform_rule_check
checker.test_target()
File "/home/jcerny/work/git/scap-security-guide/tests/ssg_test_suite/oscap.py", line 683, in test_target
self._test_target()
File "/home/jcerny/work/git/scap-security-guide/tests/ssg_test_suite/rule.py", line 458, in _test_target
self._prepare_environment(test_content_by_rule_id)
File "/home/jcerny/work/git/scap-security-guide/tests/ssg_test_suite/rule.py", line 275, in _prepare_environment
self._ensure_package_present_for_all_scenarios(test_content_by_rule_id)
File "/home/jcerny/work/git/scap-security-guide/tests/ssg_test_suite/rule.py", line 265, in _ensure_package_present_for_all_scenarios
common.install_packages(self.test_env, packages_to_install)
File "/home/jcerny/work/git/scap-security-guide/tests/ssg_test_suite/common.py", line 592, in install_packages
platform = cpes_to_platform([platform_cpe])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/jcerny/work/git/scap-security-guide/tests/ssg_test_suite/common.py", line 623, in cpes_to_platform
raise ValueError(msg)
ValueError: Unable to deduce a platform from these CPEs: ['cpe:/o:suse:sles:15:sp5']
```
jan-cerny
added
Test Suite
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
Refactor the code to have less return statements in a function and reduce cognitive complexity.
Reduce code complexity
|
I was fixing this as part of an old open pull request: ad31112 But your solution is cleaner and improves the code. I will discard that commit and rebase on top of this when it gets merged. |
|
Code Climate has analyzed commit 6d0a593 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.8% (0.0% change). View more on Code Climate. |
ggbecker
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tries to fix a traceback that happens when evaluating a SLE15 data stream on a container back end when the test scenarios require to install a package into the back end.
Resolves: