Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how example ROLE_LIST are formatted #11123

Merged

Conversation

yuumasato
Copy link
Member

Description:

  • Change how example ROLE_LIST are formatted

Rationale:

  • Formatting the example ROLE_LISTs with <> was causing them to be interpreted as html markup tags and being removed.

Review Hints:

  • Build ocp4 content and review
    <ocil:boolean_question id="ocil:ssg-scc_limit_privileged_containers_question:question:1">

Formatting the example ROLE_LISTs with <> was causing them to be
interpreted as html markup tags and being removed.
@yuumasato yuumasato added the OpenShift OpenShift product related. label Sep 15, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 15, 2023

Code Climate has analyzed commit dc63204 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator

/retest

@jan-cerny
Copy link
Collaborator

/packit retest-failed

@jan-cerny
Copy link
Collaborator

/packit retest

@jan-cerny
Copy link
Collaborator

/packit test

@jan-cerny
Copy link
Collaborator

/packit build

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked that the items in both rules don't miss these variables in built OCIL with this PR.

@jan-cerny jan-cerny self-assigned this Sep 18, 2023
@jan-cerny jan-cerny added this to the 0.1.70 milestone Sep 18, 2023
@jan-cerny jan-cerny merged commit 1ab0c6b into ComplianceAsCode:master Sep 18, 2023
34 checks passed
@yuumasato yuumasato deleted the fix_scc_ocil_role_lists branch September 18, 2023 14:32
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants