Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SELinux as platform #11138

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Add SELinux as platform #11138

merged 1 commit into from
Sep 26, 2023

Conversation

teacup-on-rockingchair
Copy link
Contributor

Description:

  • Make sure SELinux variables are not checked when no selinux is enabled

Rationale:

@teacup-on-rockingchair
Add SELinux as platform
4f23065 
Make sure SELinux variables are not checked when no selinux is enabled
The effect of the above missing is that rules checls remediation will attempt changes to the system, but those were not applicable.
Also the change communicates with a side effect we observed in OpenSCAP/openscap#1959
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 26, 2023

Code Climate has analyzed commit 4f23065 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.8%.

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Sep 26, 2023
@jan-cerny jan-cerny added this to the 0.1.70 milestone Sep 26, 2023
@jan-cerny jan-cerny added the Update Rule Issues or pull requests related to Rules updates. label Sep 26, 2023
jan-cerny
jan-cerny approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified using Automatus and a RHEL 8 VM back end that when I disable SELinux in /etc/selinux/config a rule for a SEBool sebool_selinuxuser_execheap becomes notapplicable and when I switch for permissive or enforcing it becomes applicable.

@jan-cerny jan-cerny merged commit 6149c67 into ComplianceAsCode:master Sep 26, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.70
Development

Successfully merging this pull request may close these issues.
2 participants
@teacup-on-rockingchair @jan-cerny