Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily prod fix: add enable_authselect rule to pci-dss control file #11295

Merged

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • add enable_authselect to pci-dss 4 control file
  • the authselect variable is left default, i.e. "minimal" profile is selected

Rationale:

  • With the rule missing, the Authselect profile is not configured and many PAM related rules error out.

Review Hints:

Try to perform remediation with Ansible playbook before and after the commit.

With the rule missing, the profile is not configured and many PAM related rules error out.
@vojtapolasek vojtapolasek added RHEL Red Hat Enterprise Linux product related. Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates. pci-dss labels Nov 21, 2023
@vojtapolasek vojtapolasek added this to the 0.1.71 milestone Nov 21, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 21, 2023

Code Climate has analyzed commit 5dfb3a2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8%.

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Nov 21, 2023
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including this rule @vojtapolasek

@marcusburghardt marcusburghardt merged commit c2b9581 into ComplianceAsCode:master Nov 21, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Oracle Linux Oracle Linux product related. pci-dss RHEL Red Hat Enterprise Linux product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants