Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit key check in audit_rules_privileged_commands_fdisk #11306

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 27, 2023

Description:

  • Allow arbitrary audit key or no key at all in the OVAL check.
  • Fix package name to audit in tests

Rationale:

  • Ubuntu 20.04 LTS STIG v1r10 states:
Note: The "-k" allows for specifying an arbitrary identifier, and the
string after it does not need to match the example output above.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 27, 2023
Copy link

openshift-ci bot commented Nov 27, 2023

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2004 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys requested a review from a team November 28, 2023 12:42
@dodys dodys self-assigned this Nov 28, 2023
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Nov 28, 2023
Allow arbitrary audit key in the check. Ubuntu 20.04 LTS STIG v1r10 states:
```
Note: The "-k" allows for specifying an arbitrary identifier, and the
string after it does not need to match the example output above.
```
Copy link

codeclimate bot commented Nov 28, 2023

Code Climate has analyzed commit 130b73e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented Nov 28, 2023

/packit retest-failed

@dodys
Copy link
Contributor

dodys commented Nov 28, 2023

/packit test

@vojtapolasek vojtapolasek added this to the 0.1.72 milestone Nov 29, 2023
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit a69d3ad into ComplianceAsCode:master Dec 6, 2023
34 of 38 checks passed
@vojtapolasek vojtapolasek added the OVAL OVAL update. Related to the systems assessments. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Ubuntu STIG "audit fdisk" rule more flexible.
3 participants