Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Files' level key must be an array #11417

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 4, 2024

Description:

  • Require the levels key in the policy files to be an array
  • Fix an existing policy

Rationale:

Fixes #11389

Review Hints:

  • Make the levels in your favorite control not an array and then try and build it. Notice the build failure.

By having level be string odd things happen else where.
For example render policy with the issue results in something like
the following:


* l
* e
@Mab879 Mab879 added bugfix Fixes to reported bugs. Infrastructure Our content build system labels Jan 4, 2024
@Mab879 Mab879 added this to the 0.1.72 milestone Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 4, 2024

Code Climate has analyzed commit 33d0227 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek self-assigned this Jan 5, 2024
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@vojtapolasek vojtapolasek merged commit 2055e99 into ComplianceAsCode:master Jan 5, 2024
38 checks passed
@Mab879 Mab879 deleted the fix_11389 branch January 5, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Levels on control cis_ocp_1_4_0 are not a list
2 participants