Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump geekyeggo/delete-artifact from 2 to 4" #11481

Conversation

vojtapolasek
Copy link
Collaborator

Reverts #11407

This change prevents efficient review of CI tests. It requires some changes in workflow files, but it is not clear what changes are required. It should be investigated.

@vojtapolasek vojtapolasek added this to the 0.1.72 milestone Jan 25, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 The image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11481

Copy link

codeclimate bot commented Jan 25, 2024

Code Climate has analyzed commit 9a054e6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@marcusburghardt
Copy link
Member

marcusburghardt commented Jan 25, 2024

The new version doesn't seem to be buggy, but implements a reasonable new feature. We will need to update it any way soon or later. The automatus tests are working properly (the tasks that really matters) but can't remove a file at the end. In practical we have to access these failed tests to confirm if they are not also showing a test scenario error. I don't think there is enough benefits reverting this update now.

Is not possible to simply disable the task which is trying to remove the file, for example?

@Mab879 Mab879 self-assigned this Jan 25, 2024
@vojtapolasek
Copy link
Collaborator Author

You are correct @marcusburghardt .
I created #11482
Feel free to close this PR. I will also create associated issue so that we don't forget about this thing and we investigate it more. I consider this fix to be temporary.

@marcusburghardt
Copy link
Member

@Mab879 we can close this in favor of #11482

@Mab879
Copy link
Member

Mab879 commented Jan 25, 2024

@Mab879 we can close this in favor of #11482

Makes sense to me.

@Mab879
Copy link
Member

Mab879 commented Jan 25, 2024

Closing in favor #11482

@Mab879 Mab879 closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants