add namespace parameter for cluster-test #11824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
this pr adds the ability to define a --namespace parameter for cluster-test in add_kubernetes_rule.py and defines "openshift-compliance" as default
Rationale:
while running
./utils/add_kubernetes_rule.py cluster-test --rule kubelet_anonymous_auth
there were sometimes empty results.this was caused by not switching to
openshift-compliance
namespace before running the command. To fix this I added a--namespace
withopenshift-compliance
as default.Review Hints:
deployments with non default namespace (not
openshift-compliance
) have a workflow impact.before:
oc project $namespace
./utils/add_kubernetes_rule.py cluster-test --rule kubelet_anonymous_auth
after:
./utils/add_kubernetes_rule.py cluster-test --rule kubelet_anonymous_auth --namespace $namespace