Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule file_owner_journalctl #11835

Merged
merged 1 commit into from
May 7, 2024
Merged

Add rule file_owner_journalctl #11835

merged 1 commit into from
May 7, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 17, 2024

Description:

  • New rule for auditing ownership of journalctl command
  • Satisfies STIG requirement UBTU-22-232100
  • Based on file_owner_system_journal

@mpurg mpurg requested a review from a team as a code owner April 17, 2024 08:16
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 17, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11835
This image was built from commit: ebc4bbb

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11835

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11835 make deploy-local

@dodys dodys self-assigned this Apr 17, 2024
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. New Rule Issues or pull requests related to new Rules. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 17, 2024
@dodys dodys requested review from a team April 17, 2024 11:07
@dodys
Copy link
Contributor

dodys commented Apr 17, 2024

Added red-hatters and suse maintainers as this new rule might be relevant for them
@marcusburghardt @Mab879 @teacup-on-rockingchair

@mpurg mpurg force-pushed the ubuntu_2204_stig_232100 branch 2 times, most recently from c6ca4de to 17a0629 Compare April 18, 2024 09:04
teacup-on-rockingchair
teacup-on-rockingchair approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Mab879
Mab879 requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a rebase on latest master.

@mpurg
Copy link
Contributor Author

mpurg commented Apr 25, 2024

@Mab879 rebased.

Mab879
Mab879 reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue.

linux_os/guide/system/logging/journald/file_owner_journalctl/rule.yml Outdated Show resolved Hide resolved
@mpurg mpurg force-pushed the ubuntu_2204_stig_232100 branch 2 times, most recently from 60c3a03 to 2f43204 Compare April 30, 2024 10:22
@mpurg
Add rule file_owner_journalctl
ebc4bbb 
- New rule for auditing ownership of journalctl command
- Satisfies STIG requirement UBTU-22-232100
- Based on file_owner_system_journal
@mpurg
Copy link
Contributor Author

mpurg commented Apr 30, 2024

Rebased to master due to failing tests.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 30, 2024

Code Climate has analyzed commit ebc4bbb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented May 1, 2024

/packit build

@mpurg
Copy link
Contributor Author

mpurg commented May 6, 2024 •
edited
Loading

Hi @Mab879 , could you review the fix. Thanks.

Mab879
Mab879 approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

dodys
dodys approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit f183031 into ComplianceAsCode:master May 7, 2024
110 of 113 checks passed
@Mab879 Mab879 added this to the 0.1.74 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

@teacup-on-rockingchair teacup-on-rockingchair teacup-on-rockingchair approved these changes

@Mab879 Mab879 Mab879 approved these changes

Assignees

@dodys dodys

Labels
New Rule Issues or pull requests related to new Rules. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Milestone
0.1.74
Development

Successfully merging this pull request may close these issues.
4 participants
@mpurg @dodys @Mab879 @teacup-on-rockingchair