Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stabilization] OCP Update variable filter to consider go_template #11955

Merged

Conversation

yuumasato
Copy link
Member

Description:

Rationale:

  • Let's ensure that released OCP content works.
    Without this the Compliance Operator fatal errors when scanning with a rule whose variable is not included.

Review Hints:

  • Build before and after and check the count difference in XCCDF Variables included.
    grep -r "Value.*id=" /tmp/ssg-ocp4-ds.xml

  • Check whether the Variable hypershift_cluster is in the data stream.

Update the variable filter to find if a rule is using go-template, if so find any var being used, add them to var list for that rule
Copy link

github-actions bot commented May 7, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented May 7, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11955
This image was built from commit: e93e630

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11955

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11955 make deploy-local

@yuumasato yuumasato requested review from Honny1 and jan-cerny and removed request for Honny1 May 7, 2024 11:46
@yuumasato yuumasato added this to the 0.1.73 milestone May 7, 2024
Copy link
Collaborator

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mab879 Mab879 self-assigned this May 7, 2024
@Mab879 Mab879 merged commit a7bc0cb into ComplianceAsCode:stabilization-v0.1.73 May 7, 2024
103 checks passed
@yuumasato yuumasato deleted the backport_11906 branch May 7, 2024 16:18
@Mab879 Mab879 added the bugfix Fixes to reported bugs. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants