Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCE check for ufw_rate_limit for Ubuntu #11998

Merged
merged 1 commit into from
May 17, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented May 15, 2024

Description:

  • Added SCE check for rule ufw_rate_limit for Ubuntu (STIG rules UBTU-20-010446, UBTU-22-251025)

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 15, 2024
Copy link

openshift-ci bot commented May 15, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2004 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_ufw_rate_limit'.
--- xccdf_org.ssgproject.content_rule_ufw_rate_limit
+++ xccdf_org.ssgproject.content_rule_ufw_rate_limit
@@ -5,6 +5,25 @@
 [description]:
 The operating system must configure the uncomplicated firewall to
 rate-limit impacted network interfaces.
+
+Check all the services listening to the ports with the following
+command:
+$ sudo ss -l46ut
+Netid State Recv-Q Send-Q Local Address:Port Peer Address:Port Process
+tcp LISTEN 0 128 [::]:ssh [::]:*
+
+For each entry, verify that the ufw is configured to rate limit the
+service ports with the following command:
+$ sudo ufw status
+
+If any port with a state of "LISTEN" is not marked with the "LIMIT"
+action, run the following command, replacing "service" with the
+service that needs to be rate limited:
+$ sudo ufw limit "service"
+
+Rate-limiting can also be done on an interface. An example of adding
+a rate-limit on the eth0 interface follows:
+$ sudo ufw limit in on eth0
 
 [reference]:
 CCI-002385

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11998
This image was built from commit: bdb698b

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11998

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11998 make deploy-local

Copy link

codeclimate bot commented May 15, 2024

Code Climate has analyzed commit bdb698b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the Ubuntu Ubuntu product related. label May 16, 2024
@dodys dodys requested a review from a team May 17, 2024 07:44
@dodys dodys self-assigned this May 17, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 0ec2d6e into ComplianceAsCode:master May 17, 2024
104 of 109 checks passed
@Mab879 Mab879 added the Bash Bash remediation update. label Aug 8, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants