Add subscription file for ROSA installs #12004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ROSA clusters only have worker nodes, we need to modify the subscription to allow the operator to schedule on worker nodes. Without this, ROSA installations will spin waiting for master nodes to schedule on. This will get wired up to CI through the ocp4e2e test suite in a separate PR: ComplianceAsCode/ocp4e2e#41
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
|
Code Climate has analyzed commit 7e9e212 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
|
Note to reviewers: You should be able to test this on a ROSA cluster by applying the subscription file and the operator should come up like it normally would. |
yuumasato
reviewed
May 17, 2024
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 17, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 17, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
|
/packit retest-failed |
1 similar comment
|
/packit retest-failed |
yuumasato
approved these changes
May 17, 2024
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 17, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 21, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 21, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 22, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 23, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 23, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 23, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
rhmdnd
added a commit
to rhmdnd/release
that referenced
this pull request
May 23, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
openshift-merge-bot bot
pushed a commit
to openshift/release
that referenced
this pull request
May 23, 2024
We've made some changes to the Compliance Operator so that it supports running on managed offerings. This commit wires up testing CIS and PCI-DSS node profiles on ROSA so that we can assess the compliance posture of those profiles on the platform. The following related PRs need to land before this change will wire things up appropriately: ComplianceAsCode/content#12004 ComplianceAsCode/ocp4e2e#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ROSA clusters only have worker nodes, we need to modify the
subscription to allow the operator to schedule on worker nodes.
Without this, ROSA installations will spin waiting for master nodes to
schedule on.
This will get wired up to CI through the ocp4e2e test suite in a
separate PR:
ComplianceAsCode/ocp4e2e#41