Github Action Ansible shell
module changes check
#12014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
CI check to notify if a Ansible
shell
/command
module usage has been changed.It's preferred to use specific Ansible module rather than abuse
shell
(command
) module. So we want to haveshell
(command
) module used only in approved corner cases when there is no other option.Review Hints:
SeeCompare DS / Generate Diff (pull_request)
check and bot PR comments.There is extra commit to trigger the updated CI. The commit must be removed before merging.
It's seems as it's not possible to show it in CaC/content repo CI before merge. To show the check, I've created extra PR in my private repo - mildas#3 (see
Compare DS / Generate Diff (pull_request)
check and bot PR comments)