Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct permissions in macro bash_enable_dconf_user_profile #12051

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jun 7, 2024

Description

  • Set correct permissions for dconf profiles in macro bash_enable_dconf_user_profile (0644)
  • Fix case where the file exists but is empty.

Also small fix for scenario where the file exists but is empty.
Copy link

openshift-ci bot commented Jun 7, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jun 7, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12051
This image was built from commit: e761caa

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12051

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12051 make deploy-local

@mpurg
Copy link
Contributor Author

mpurg commented Jun 7, 2024

@marcusburghardt can you look at the failed tests please?

Copy link

codeclimate bot commented Jun 7, 2024

Code Climate has analyzed commit e761caa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Jun 10, 2024
@dodys dodys requested a review from a team June 10, 2024 08:38
@dodys
Copy link
Contributor

dodys commented Jun 10, 2024

/packit build

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 36de0d0 into ComplianceAsCode:master Jun 10, 2024
106 of 108 checks passed
@marcusburghardt marcusburghardt added this to the 0.1.74 milestone Jun 10, 2024
@marcusburghardt marcusburghardt added Bash Bash remediation update. Update Template Issues or pull requests related to Templates updates. labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. Update Template Issues or pull requests related to Templates updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants