Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure code consistency by using aide_conf_path var #12066

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Make use of aide_conf_path var in rule aide_check_audit_tools to ensure consistency
  • Enable tests for Ubuntu

Rationale:

  • Some part of the rule aide_check_audit_tools still use hard-coded aide conf path

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 14, 2024
Copy link

openshift-ci bot commented Jun 14, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12066
This image was built from commit: b846594

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12066

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12066 make deploy-local

Copy link

codeclimate bot commented Jun 14, 2024

Code Climate has analyzed commit b846594 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys dodys requested a review from a team June 14, 2024 13:50
@dodys dodys self-assigned this Jun 14, 2024
@marcusburghardt marcusburghardt added Update Rule Issues or pull requests related to Rules updates. enhancement General enhancements to the project. labels Jun 17, 2024
@marcusburghardt marcusburghardt added this to the 0.1.74 milestone Jun 17, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 3628e56 into ComplianceAsCode:master Jun 18, 2024
84 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. needs-ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants