Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debian12 automatus workflow #12128

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

a-skr
Copy link
Contributor

@a-skr a-skr commented Jul 4, 2024

Description:

  • Add a debian12 dockerfile and a github workflow to test rules on debian12

Review Hints:

  • based on automatus-ubuntu2204 workflow.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 4, 2024
Copy link

openshift-ci bot commented Jul 4, 2024

Hi @a-skr. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jul 4, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 4, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12128
This image was built from commit: c0c6cbf

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12128

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12128 make deploy-local

@Mab879
Copy link
Member

Mab879 commented Jul 17, 2024

Thanks for the PR, The Ubuntu 22.04 Automatus seems to be broken.

I'm working on a fix in #12121, however I have ran into a bit of wall, see that PR for more details.

So at this point I'm uncomfortable merging this.

@a-skr
Copy link
Contributor Author

a-skr commented Jul 18, 2024

Then, I suggest to not merge it for now. I added xsltproc as part of this PR to fix the build, and I will add other relevant fixes once PR #12121 is in a good shape.

I'm also not sure of how to test this PR from my side, so any hint would be welcome.

@Mab879
Copy link
Member

Mab879 commented Jul 18, 2024

Then, I suggest to not merge it for now. I added xsltproc as part of this PR to fix the build, and I will add other relevant fixes once PR #12121 is in a good shape.
Sounds good. Thanks.

I'm also not sure of how to test this PR from my side, so any hint would be welcome.

The best way to test this PR is to add an Automatus test scenario to a rule that works well in container in a separate commit. That should cause the Content Test Filtering to run the tests on the rule you changed. Once your workflow is done you can remove that commit via a rebase.

Something I did in the past is just add blank test (with a filename like default_state.fail.sh) to the rule package_tmux_installed.

@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label Jul 31, 2024
@jan-cerny
Copy link
Collaborator

Hi @a-skr Can you check this again? #12230 has been merged.

@a-skr a-skr force-pushed the feature/automatus-debian12 branch 5 times, most recently from 93bb746 to 28be390 Compare August 14, 2024 15:44
@Mab879 Mab879 self-assigned this Aug 14, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Aug 14, 2024
@a-skr a-skr force-pushed the feature/automatus-debian12 branch from 28be390 to a880cea Compare August 14, 2024 16:05
@a-skr a-skr force-pushed the feature/automatus-debian12 branch from a880cea to 76a8c6c Compare August 17, 2024 08:11
@a-skr a-skr force-pushed the feature/automatus-debian12 branch 7 times, most recently from ffadd5c to c0c6cbf Compare August 21, 2024 08:16
Copy link

codeclimate bot commented Aug 21, 2024

Code Climate has analyzed commit c0c6cbf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@a-skr
Copy link
Contributor Author

a-skr commented Aug 21, 2024

I think this PR can be considered for merging.

@Mab879 Mab879 merged commit c7eaf1c into ComplianceAsCode:master Aug 26, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants