-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add debian12 automatus workflow #12128
add debian12 automatus workflow #12128
Conversation
Hi @a-skr. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Thanks for the PR, The Ubuntu 22.04 Automatus seems to be broken. I'm working on a fix in #12121, however I have ran into a bit of wall, see that PR for more details. So at this point I'm uncomfortable merging this. |
Then, I suggest to not merge it for now. I added xsltproc as part of this PR to fix the build, and I will add other relevant fixes once PR #12121 is in a good shape. I'm also not sure of how to test this PR from my side, so any hint would be welcome. |
The best way to test this PR is to add an Automatus test scenario to a rule that works well in container in a separate commit. That should cause the Content Test Filtering to run the tests on the rule you changed. Once your workflow is done you can remove that commit via a rebase. Something I did in the past is just add blank test (with a filename like |
93bb746
to
28be390
Compare
28be390
to
a880cea
Compare
a880cea
to
76a8c6c
Compare
ffadd5c
to
c0c6cbf
Compare
Code Climate has analyzed commit c0c6cbf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
I think this PR can be considered for merging. |
Description:
Review Hints: