-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notes and Controls for SYS.1.6.A1-A4 #12161
Add Notes and Controls for SYS.1.6.A1-A4 #12161
Conversation
Hi @sluetze. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit 32204e8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
QE: /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I have tried this PR rebased on latest master to check whether any rule reference would conflict, and everything worked.
Description:
This PR implements mostly notes and reuses some existing rules.
Rationale:
Customer asked for BSI Profile
Review Hints:
Currently the build is broken due to reference_type used.
We have two control files (bsi_app_4_4 and bsi_sys_1_6 ) I configured both of them with reference_type: bsi expecting the autolabeling to “merge” the different requirements from the control files to the references. But this does not seem to work as expected. during the build the build fails with ValueError: Rule accounts_no_clusterrolebindings_default_service_account contains bsi reference, but this reference type is provided by bsi_sys_1_6 controls. Please remove the reference from rule.yml. even though the mentioned rule does not include a reference and also is not referenced in bsi_sys_1_6 control file
changing the reference to another name results in unknown reference (ValueError: Unknown reference type bsi_sys)
I suspect that the referencing is done for bsi_app_4_4 control file and afterwards the pre-check of the bsi_sys_1_6 for references fails.