Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce /rpmbuild-ctest-fedora CI for all Fedora versions #12176

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Jul 17, 2024

Description:

Re-introduce rpmbuild-ctest for all supported Fedora versions. The test takes srpm, builds it from sources, and runs ctest for all Fedora enabled products.

rpmbuild-ctest got necessary update related in RHSecurityCompliance/contest#224 Now, it installs recommended packages to enable more unit tests.

Also improve TMT plan regexes to not match multiple profiles.
Before:
testing-farm:centos-stream-8-x86_64:/hardening/host-os/ansible/cis - matches all cis profiles because of regex match
After:
testing-farm:centos-stream-8-x86_64:/hardening/host-os/ansible/cis - matches only cis profile as intended

Rationale:

Recently, one of our unit tests was failing on Fedora Rawhide and it was not caught by CI.

Review Hints:

See Testing Farm /rpmbuild-ctest-fedora Fedora jobs.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 17, 2024
@mildas mildas marked this pull request as draft July 17, 2024 12:38
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 17, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12176
This image was built from commit: 373a9fb

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12176

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12176 make deploy-local

@jan-cerny
Copy link
Collaborator

@mildas Is the no space left on deviceproblem caused by the fact that we build every SSG product on Fedora?

@mildas
Copy link
Contributor Author

mildas commented Jul 24, 2024

@jan-cerny Yes, from what I've checked it seems so

@mildas mildas force-pushed the fedora_ci branch 2 times, most recently from 4a4f6dc to c9665a5 Compare July 26, 2024 13:19
@Mab879 Mab879 modified the milestones: 0.1.74, 0.1.75 Jul 29, 2024
@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label Jul 31, 2024
@mildas
Copy link
Contributor Author

mildas commented Aug 6, 2024

/packit build

@Mab879
Copy link
Member

Mab879 commented Aug 30, 2024

@mildas What needs to be done to move this PR a long?

@Mab879
Copy link
Member

Mab879 commented Aug 30, 2024

/packit build

1 similar comment
@mildas
Copy link
Contributor Author

mildas commented Sep 26, 2024

/packit build

@mildas
Copy link
Contributor Author

mildas commented Sep 26, 2024

@Mab879 Sorry, I completely forgot about this PR and didn't get notification about your ping. I will investigate what is going on with Fedora and try to fix it

@mildas mildas changed the title [wip] Introduce /static-checks CI also for all Fedora versions Introduce /rpmbuild-ctest-fedora CI for all Fedora versions Sep 27, 2024
@mildas mildas marked this pull request as ready for review September 27, 2024 07:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 27, 2024
@mildas
Copy link
Contributor Author

mildas commented Sep 27, 2024

Problem related to rpmbuild fixed in Contest and PR description updated. Now it's ready for merge.

Copy link

codeclimate bot commented Sep 27, 2024

Code Climate has analyzed commit 373a9fb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Oct 8, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit c0e1c64 into ComplianceAsCode:master Oct 8, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants