Update OVAL check in accounts_password_last_change_is_in_past #12177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, this test was using a hard-coded value to compare the timestamp of password last change field.
This approach works fine in most cases but proved not robust enough when passwords were changed long time ago. The new approach uses the current timestamp instead of a hard-coded value for a more flexible and robust test.
Rationale:
Review Hints:
Essentially only the
variable_state
object was updated to use a new local variable instead of a hard-coded value.The ids of some other objects were renamed for better alignment between objects ids, without technical changes in logic.
There is no remediation for this rule, so automatus tests should be enough. e.g.: