Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slmicro5 stig add privileged commands support #12221

Conversation

svet-se
Copy link
Contributor

@svet-se svet-se commented Jul 25, 2024

Description:

  • Slmicro5 stig add privileged commands support

Rationale:

  • Update audit_rules_privileged_commands to support SLMICRO5 STIG

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 25, 2024
Copy link

openshift-ci bot commented Jul 25, 2024

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 25, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12221
This image was built from commit: 1ea63b4

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12221

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12221 make deploy-local

@teacup-on-rockingchair teacup-on-rockingchair added SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates. Update Profile Issues or pull requests related to Profiles updates. labels Jul 25, 2024
@teacup-on-rockingchair teacup-on-rockingchair force-pushed the slmicro5-stig-add-privileged-commands-support branch from ee22047 to bbbc5ce Compare July 29, 2024 11:56
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.74 milestone Jul 29, 2024
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mab879
Copy link
Member

Mab879 commented Jul 29, 2024

@svet-se This PR needs a rebase.

@teacup-on-rockingchair teacup-on-rockingchair force-pushed the slmicro5-stig-add-privileged-commands-support branch from bbbc5ce to 1ea63b4 Compare July 29, 2024 14:35
Copy link

codeclimate bot commented Jul 29, 2024

Code Climate has analyzed commit 1ea63b4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair merged commit a625d70 into ComplianceAsCode:master Jul 29, 2024
89 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants