Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Remove installed_OS_is_FIPS_certified from sshd_use_approved_ciphers #12242

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 30, 2024

Description:

Remove installed_OS_is_FIPS_certified from sshd_use_approved_ciphers

Rationale:

Closes #12096

@Mab879 Mab879 added the bugfix Fixes to reported bugs. label Jul 30, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jul 30, 2024
Copy link

openshift-ci bot commented Jul 30, 2024

@Mab879: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-images 6d480f2 link true /test 4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
OVAL for rule 'xccdf_org.ssgproject.content_rule_sshd_use_approved_ciphers' differs.
--- oval:ssg-sshd_use_approved_ciphers:def:1
+++ oval:ssg-sshd_use_approved_ciphers:def:1
@@ -1,5 +1,3 @@
-criteria AND
-extend_definition oval:ssg-installed_OS_is_FIPS_certified:def:1
 criteria OR
 criteria AND
 extend_definition oval:ssg-sshd_not_required_or_unset:def:1

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12242
This image was built from commit: 6d480f2

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12242

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12242 make deploy-local

Copy link

codeclimate bot commented Jul 30, 2024

Code Climate has analyzed commit 6d480f2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jul 31, 2024
@jan-cerny jan-cerny merged commit b3babf0 into ComplianceAsCode:master Jul 31, 2024
94 of 97 checks passed
@Mab879 Mab879 deleted the fix_12096_master branch July 31, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sshd_use_approved_ciphers fails for all CIS profiles in all test cases
2 participants