Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate ASCS RHEL profiles lastlog via sshd #12249

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

dahaic
Copy link
Contributor

@dahaic dahaic commented Jul 31, 2024

Description:

  • Consolidating last login information to only one method - sshd based for Essential 8 and ISM_O, for RHEL8, RHEL9 and RHEL10

Rationale:

  • As E8 and ISM O profiles were using different methods to print last login information. This results in different timestamps in logs, creating inconvenience. Using just one method is preferrable.

As E8 and ISM O profiles were using different methods to print last
login information. This results in different timestamps in logs,
creating inconvenience. Using just one method is preferrable.
@dahaic dahaic requested a review from a team as a code owner July 31, 2024 17:07
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Jul 31, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Jul 31, 2024
Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12249
This image was built from commit: 5f9c3db

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12249

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12249 make deploy-local

Copy link

codeclimate bot commented Jul 31, 2024

Code Climate has analyzed commit 5f9c3db and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added RHEL Red Hat Enterprise Linux product related. Update Profile Issues or pull requests related to Profiles updates. labels Jul 31, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit 47e7bdb into ComplianceAsCode:master Aug 1, 2024
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL Red Hat Enterprise Linux product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants