Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and update install_vm.py script #12254

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Review and update install_vm.py script #12254

merged 8 commits into from
Aug 2, 2024

Conversation

marcusburghardt
Copy link
Member

Description:

This script helps us to quickly deploy a VM for content tests.
When I tried to use it to create a RHEL 10 VM, I got errors and the installation didn't succeed.

Trying to investigate the issue I saw opportunities to improve the script.
So I decided to fix the current issues and refactor it make it simpler, more flexible and easier to be used.

Rationale:

Better tooling for maintainers.

Review Hints:

Try to install a RHEL 10 vm using the install_vm.py script.

@marcusburghardt
Include osinfo option in install_vm.py script
adef3f5 
This option is necessary to virt-install command when a system can't be
detected, for example when a not yet released product needs to be
provisioned for testing.

Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
@marcusburghardt
Remove centos7 and include rhel10
50f1cfe 
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
@marcusburghardt
Simplify handle of urls
7f374e9 
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
@marcusburghardt
Simplify handle of ssh pub_key
f8a171a 
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
@marcusburghardt
Optimize script output
ab2c45c 
VMs installed with this script are in general for test. Sometimes
they fail and we need to isolate the issue. So now the virt-install
command is always shown before starting the installation to make things
easier.

Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
@marcusburghardt
Simplify error function
751284d 
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
@marcusburghardt
Simplify strings formats
840c9e8 
Replace the traditional call for format method for its shorter
alternative. This makes the lines easier to be read and maintained.

Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
@marcusburghardt
Review kickstart file for test_suite
dd705b8 
Just included RHEL 10 comment.

Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
@marcusburghardt marcusburghardt added enhancement General enhancements to the project. Test Suite Update in Test Suite. refactoring Improvement which, once completed, will enable the project to progress faster. labels Aug 1, 2024
@marcusburghardt marcusburghardt added this to the 0.1.75 milestone Aug 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Aug 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12254
This image was built from commit: dd705b8

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12254

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12254 make deploy-local

@codeclimate CodeClimate
Copy link

codeclimate bot commented Aug 1, 2024

Code Climate has analyzed commit dd705b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Aug 1, 2024

/test 4.13-images

Mab879
Mab879 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit 8772fda into ComplianceAsCode:master Aug 2, 2024
97 checks passed
@marcusburghardt marcusburghardt deleted the install_vm_rhel10 branch August 2, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
enhancement General enhancements to the project. refactoring Improvement which, once completed, will enable the project to progress faster. Test Suite Update in Test Suite.
Projects
None yet
Milestone
0.1.75
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusburghardt @Mab879