Bring bash version in-sync with Ansible

[droopy4096]

Description:

• Currently ash script for adjusting umask in /etc/bashrc is breaking existing /etc/bashrc

Rationale:

Ansible script uses much more reasonable regexp to replace only umask value whereas bash script replaces value and anything that follows.

Review Hints:

[openshift-ci]

Hi @droopy4096. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_umask_etc_bashrc' differs.
--- xccdf_org.ssgproject.content_rule_accounts_umask_etc_bashrc
+++ xccdf_org.ssgproject.content_rule_accounts_umask_etc_bashrc
@@ -9,7 +9,7 @@
 
 
 grep -q "^[^#]*\bumask" /etc/bashrc && \
-  sed -i -E -e "s/^([^#]*\bumask).*/\1 $var_accounts_user_umask/g" /etc/bashrc
+  sed -i -E -e "s/^([^#]*\bumask)[[:space:]]+[[:digit:]]+/\1 $var_accounts_user_umask/g" /etc/bashrc
 if ! [ $? -eq 0 ]; then
     echo "umask $var_accounts_user_umask" >> /etc/bashrc
 fi

[Mab879]

/ok-to-test

[github-actions]

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12398
This image was built from commit: 8516678

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12398

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12398 make deploy-local

[codeclimate]

Code Climate has analyzed commit 8516678 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

[droopy4096]

I'm failing to see what the issue is from CI output. Can someone take a look and let me know what needs to be fixed there?

[jan-cerny]

The CI problem occurs only on Debian, on other systems it doesn't manifest. I have checked the logs (you can download them in the Summary tab in the test run details of the action). The problem is that the test scenarios fail to prepare because there is no /etc/bashrc on Debian. I think the test scenarios should be changed to ensure that this bashrc file always exist prior to the modification. But this problem has already been there and isn't caused by your PR. Thank you.

[jan-cerny]

On Debian and other systems the name of the file "/etc/bash.bashrc". I have reported an issue about it: #12409.