Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e8 profile for RHEL 10 #12402

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Update e8 profile for RHEL 10 #12402

merged 1 commit into from
Sep 19, 2024

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • remove rule exclustions which are not valid anymore
  • set cryptopolicy to default because the nosha submodule does not exist in RHEL 10
  • exclude rule which is reported as failed after remediation with ansible

Rationale:

  • make profiles sane for rhel10 product

Review Hints:

  • evaluate the profile through automatus while remediating through Bash or Ansible

@vojtapolasek
modify the RHEL 10 profile so that it is greenafter remediation
63b6ad1 
- remove rule exclustions which are not valid anymore
- set cryptopolicy to default because the nosha submodule does not exist in RHEL 10
- exclude rule which is reported as failed after remediation with ansible
@vojtapolasek vojtapolasek added Update Profile Issues or pull requests related to Profiles updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Sep 19, 2024
@vojtapolasek vojtapolasek requested a review from a team as a code owner September 19, 2024 12:16
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12402
This image was built from commit: 63b6ad1

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12402

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12402 make deploy-local

@codeclimate CodeClimate
Copy link

codeclimate bot commented Sep 19, 2024

Code Climate has analyzed commit 63b6ad1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added this to the 0.1.75 milestone Sep 19, 2024
@Mab879 Mab879 self-assigned this Sep 19, 2024
Mab879
Mab879 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@Mab879 Mab879 merged commit 993c564 into ComplianceAsCode:master Sep 19, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
RHEL10 Red Hat Enterprise Linux 10 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.75
Development

Successfully merging this pull request may close these issues.
3 participants
@vojtapolasek @Mab879 @marcusburghardt