Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule tftp_uses_secure_mode_systemd #12436

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Sep 27, 2024

Description:

Add new rule tftp secure mode for systems that use systemd. The old rule tftp_uses_secure_mode uses xinetd which no longer used in new versions of RHEL.

There is no remediation or checks since ExecStart
cannot be obtained from dbus.

Rationale:

Updates for RHEL 10

@Mab879 Mab879 added the New Rule Issues or pull requests related to new Rules. label Sep 27, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Sep 27, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel10 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
xccdf_org.ssgproject.content_rule_tftpd_uses_secure_mode is missing in new data stream.

Copy link

github-actions bot commented Sep 27, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12436
This image was built from commit: 3374111

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12436

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12436 make deploy-local


warnings:
- general: |-
A remedation is not currently available due limits of the checking engine.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checking engine isn't a reason of a missing remediation. You can have remediations that would be executed if they run separately, Ansible Playbook or a Bash remediation.

I suggest rewording this and explaining why there is no OVAL check.

Comment on lines 24 to 25
Use <tt>sudo systemctl edit tftp</tt> to adjust the <tt>ExecStart</tt> to
be <tt>/usr/sbin/in.tftpd -s {{{ xccdf_value("var_tftpd_secure_directory") }}}</tt>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rather a fix text not a check.

@@ -0,0 +1,38 @@
documentation_complete: true

title: 'Ensure tftp Daemon Uses Secure Mode Using systemd'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is weird: uses ... using

Configure tftp systemd service to use secure mode

@jan-cerny jan-cerny self-assigned this Sep 30, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Sep 30, 2024
Add new rule tftp secure mode for systems that use systemd. The old rule tftp_uses_secure_mode uses xinetd which no longer used in new versions of RHEL.

There is no remediation or checks since ExecStart
cannot be obtained from dbus.
Copy link

codeclimate bot commented Sep 30, 2024

Code Climate has analyzed commit 3374111 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit 29981c0 into ComplianceAsCode:master Oct 1, 2024
94 of 100 checks passed
@Mab879 Mab879 deleted the new_rule_tftp branch October 1, 2024 15:37
jan-cerny pushed a commit to jan-cerny/scap-security-guide that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Rule Issues or pull requests related to new Rules.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants