Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install_smartcard_packages for RHEL10 #12459

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Oct 2, 2024

Description:

Update install_smartcard_packages for RHEL10

Rationale:

The pkcs11-provider is the correct name for RHEL 10.

The pkcs11-provider is the correct name for RHEL 10.
@Mab879 Mab879 added Update Rule Issues or pull requests related to Rules updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Oct 2, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Oct 2, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12459
This image was built from commit: 651dc1e

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12459

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12459 make deploy-local

Copy link

codeclimate bot commented Oct 2, 2024

Code Climate has analyzed commit 651dc1e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek self-assigned this Oct 3, 2024
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. The fail of automatus on Debian is expected, it seems the rule is not in the data stream.

@vojtapolasek vojtapolasek merged commit b9cb29f into ComplianceAsCode:master Oct 3, 2024
99 of 100 checks passed
@Mab879 Mab879 deleted the update_smart_card_packages_rhel10 branch October 3, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL10 Red Hat Enterprise Linux 10 product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants