Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that platforms is valid in Automatus tests #12505

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Oct 16, 2024

Description:

  • Update tests/validate_automatus_metadata.py ensure that platforms is valid in Automatus tests
  • Fix findings

Rationale:

Ensure automatus is working correctly

@Mab879 Mab879 added the Infrastructure Our content build system label Oct 16, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Oct 16, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

slmicro5 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879
Copy link
Member Author

Mab879 commented Oct 16, 2024

FYI @teacup-on-rockingchair

Copy link

codeclimate bot commented Oct 16, 2024

Code Climate has analyzed commit 21e8c0f and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.0% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Oct 17, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have broken the metadata in linux_os/guide/system/selinux/selinux_state/tests/selinux_enforcing.pass.sh in various ways and then I have verified that ctest --verbose -R validate_automatus_metadata fails successfully.

@jan-cerny jan-cerny merged commit 8b73834 into ComplianceAsCode:master Oct 17, 2024
96 of 104 checks passed
@Mab879 Mab879 deleted the update_tests_validate_automatus_metadata.py branch October 17, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants