Stop SCAP content validation if not necessary #12523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SCAP content validation is very time consuming. The CTest test cases that perform the validation takes the most time of the CI runs. However, the likelihood of catching a serious problem by these tests is low. If anybody modifies an OVAL, they most likely try to run it in OpenSCAP or in Automatus tests and these tests would fail because of invalid OVAL. We will introduce a new CMake option SSG_SCAP_VALIDATION_ENABLED. If this option is enable, CTest tests will contain validation of built SCAP content. The default behavior of the system doesn't change, the option is set to TRUE by default therefore the validation will be still turned on by default. Then, we set this option to OFF in select GitHub Actions CI jobs which will stop executing SCAP content validation in these jobs.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit f2d5488 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SCAP content validation is very time consuming. The CTest test cases that perform the validation takes the most time of the CI runs. However, the likelihood of catching a serious problem by these tests is low. If anybody modifies an OVAL, they most likely try to run it in OpenSCAP or in Automatus tests and these tests would fail because of invalid OVAL.
We will introduce a new CMake option SSG_SCAP_VALIDATION_ENABLED. If this option is enable, CTest tests will contain validation of built SCAP content. The default behavior of the system doesn't change, the option is set to TRUE by default therefore the validation will be still turned on by default.
Then, we set this option to OFF in select GitHub Actions CI jobs which will stop executing SCAP content validation in these jobs.
The time of "Gate / Build, Test on Fedora Latest (Container) (pull_request)" reduced from 41 min to 26 min with this change.