Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules removed from RHEL8/RHEL9 profiles back to datastream #12572

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Nov 5, 2024

Description:

Add back rules that were identifier by our daily productization that they got removed from datastream.

Rationale:

#12559 removed several rules from RHEL8 STIG profile. However, few of them were used only in STIG profile and thus the change removed them from datastream.

#12551 removed several rules from RHEL9 STIG profile. Similarly as RHEL8, these rules were only part of STIG profile.

Review Hints:

Check the rules are back in datastream.

@mildas mildas requested a review from Mab879 November 5, 2024 08:56
@mildas mildas requested a review from a team as a code owner November 5, 2024 08:56
Copy link

github-actions bot commented Nov 5, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 5, 2024

Code Climate has analyzed commit 1d45454 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.75 milestone Nov 5, 2024
@Mab879 Mab879 self-assigned this Nov 5, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit 91ecdc1 into ComplianceAsCode:master Nov 5, 2024
104 of 105 checks passed
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants