Skip to content

[Ubuntu]: UBTU-24-300016 #13373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Implement stig rule UBTU-24-300016
  • Set package name of libpwquality for Ubuntu
  • Exclude extend_definition enable_authselect for Ubuntu
  • Use pam-auth-update to insert "retry" option into common-password instead of pwquality.conf

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 22, 2025
Copy link

openshift-ci bot commented Apr 22, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dodys dodys self-assigned this Apr 22, 2025
@dodys dodys added this to the 0.1.77 milestone Apr 22, 2025
@dodys dodys added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Apr 22, 2025
@dodys dodys requested a review from a team April 22, 2025 17:20
@dodys
Copy link
Contributor

dodys commented Apr 22, 2025

/packit build

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has ctest issues.

Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@alanmcanonical alanmcanonical changed the title [UBuntu]: UBTU-24-300016 [Ubuntu]: UBTU-24-300016 Apr 23, 2025
@alanmcanonical
Copy link
Contributor Author

@dodys Here is the ctest result for all products
image

@dodys
Copy link
Contributor

dodys commented Apr 23, 2025

@Mab879 I believe the fedora test issue might be relevant to you

@alanmcanonical
Copy link
Contributor Author

@Mab879
The failed Automatus Fedora might caused by lack of package gawk, after I install gawk on fedora container and re-apply the remediation the option successfully changed to 3.

{{% macro bash_ensure_authselect_custom_profile() -%}}
CURRENT_PROFILE=$(authselect current -r | awk '{ print $1 }')
needs awk

@Mab879
Copy link
Member

Mab879 commented Apr 23, 2025

Thanks for the info, I will take a look.

A rebase should fix the testing farm errors.

Copy link

codeclimate bot commented Apr 24, 2025

Code Climate has analyzed commit 4b6cf45 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented Apr 24, 2025

/packit build

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 3c9954d into ComplianceAsCode:master Apr 28, 2025
98 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants