-
Notifications
You must be signed in to change notification settings - Fork 760
update audit_rules_networkconfig_modification for Debian #14145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @a-skr. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
72f1bd6 to
eefda01
Compare
Mab879
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I think is fine, but you need update stable products. See the failing Debian CI for more details.
|
I will update them. I was never sure of whether I shall update them by hand, or if they are automatically updated as part of a later release process. |
| @@ -0,0 +1 @@ | |||
| ubuntu.xml No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not in favor of using symlinks. Instead of the symlink, please put a copy of the file. Or even better try to consolidate all existing OVAL checks into a single file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look into it next week, then.
Description:
Rationale:
Review Hints: