Add new rule accounts_passwords_pam_faillock_unlock_time_with_zero #14188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new rule `accounts_passwords_pam_faillock_unlock_time_with_zero` which is almost the same as `accounts_passwords_pam_faillock_unlock_time`, but it allows the `unlock_time` faillock parameter to be set either to zero or to value greater than the value of the `var_accounts_passwords_pam_faillock_unlock_time` variable. By allowing also 0, we better align with the requirement 5.3.2.1.2 of the RHEL 10 CIS Benchmark v1.0.1. Resolves: https://issues.redhat.com/browse/OPENSCAP-6095
jan-cerny
requested review from
a team,
Mab879,
matusmarhefka and
vojtapolasek
as code owners
jan-cerny
added
New Rule
Mab879
requested changes
Nov 26, 2025
...t_password_attempts/accounts_passwords_pam_faillock_unlock_time_with_zero/ansible/shared.yml
Show resolved
Hide resolved
| @@ -0,0 +1,6 @@ | |||
| # platform = multi_platform_all | |||
|
|
||
| <!-- pam_faillock.so parameters can be defined directly in pam files or, in newer | ||
| versions, in {{{ pam_faillock_conf_path }}}. The last is the recommended option when | ||
| available. Also, is the option used by auselect tool. However, regardless the |
Member
There was a problem hiding this comment.
Suggested change
| available. Also, is the option used by auselect tool. However, regardless the | |
| available. Also, is the option used by authselect tool. However, regardless the |
|
@jan-cerny: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Collaborator
Author
|
I have fixed shebangs and typo |
Mab879
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new rule
accounts_passwords_pam_faillock_unlock_time_with_zerowhich is almost the same asaccounts_passwords_pam_faillock_unlock_time, but it allows theunlock_timefaillock parameter to be set either to zero or to value greater than the value of thevar_accounts_passwords_pam_faillock_unlock_timevariable. By allowing also 0, we better align with the requirement 5.3.2.1.2 of the RHEL 10 CIS Benchmark v1.0.1.Resolves: https://issues.redhat.com/browse/OPENSCAP-6095