Skip to content

Conversation

@comps
Copy link
Collaborator

@comps comps commented Jan 6, 2026

Description:

This extends #14203 by using atex from PyPI directly (instead of using git), hopefully resulting in a more stable version.

It also takes advantage of the (new) LZMAJSONAggregator that transparently on-the-fly compresses both the results.json.xz and all files uploaded by tests. This is less critical now (with just STIG), but once we start extending the workflow to all profiles and (later) to run the full "daily productization" set of tests, it will be super useful to keep Testing Farm artifact storage within reasonable limits.

Yes, mixing gz / xz in the code is a bit weird now (eg. using .gz for results.sqlite.gz), but that's just a result of the project separation:

  • *.xz comes from an Aggregator (results + uploaded files)
  • .sqlite.gz comes from atex-html, a separate project that requires Gzip compression, because web browsers don't support LZMA

Also note atex-html/json2db.py has been updated to support .xz inputs, and (from my testing) seems to work well with all of .json / .json.gz / json.xz.

Rationale:

Some rough Gzip / LZMA estimates show about 20% to 400% improvements in compressed size differences, indicating that LZMA does make sense, especially when RHSecurityCompliance/contest#497 is merged and ALL test uploaded files are uncompressed.

Review Hints:

Note that I am intentionally keeping https://github.com/RHSecurityCompliance/atex (main branch) behind the current 0.11 ATEX release (on PyPI, and tagged on Github) to prevent existing CaC/content PRs breaking on the API change.
But a few days after this PR gets merged, I'll update Github too, so hopefully everyone has rebased by then.

Unfortunately, as indicated by @ggbecker , I don't think we can test this PR using existing Github workflows, so review + blind merge might be needed here.

@Mab879 Mab879 self-assigned this Jan 6, 2026
@Mab879 Mab879 added this to the 0.1.80 milestone Jan 6, 2026
@Mab879 Mab879 added the Infrastructure Our content build system label Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

ATEX Test Results

Test artifacts have been submitted to Testing Farm.

Results: View Test Results
Workflow Run: View Workflow Details

This comment was automatically generated by the ATEX workflow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need to point to PyPi?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed, thanks!

comps added 2 commits January 6, 2026 20:23
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
@comps comps force-pushed the use_atex_from_pypi branch from 3fed297 to dc67da7 Compare January 6, 2026 19:24
@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2026

@comps: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-openshift-node-compliance dc67da7 link true /test e2e-aws-openshift-node-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Mab879 Mab879 merged commit 414403b into ComplianceAsCode:master Jan 6, 2026
140 of 142 checks passed
@comps comps deleted the use_atex_from_pypi branch January 6, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Our content build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants