Skip to content

Conversation

@ggbecker
Copy link
Member

@ggbecker ggbecker commented Jan 8, 2026

Description:

  • Compare DS job: store PR info to be used by compare ds workflow.

Rationale:

Review Hints:

  • Since this is a workflow_run type of workflow, we will need to merge first to see if it fixes the issue.

@ggbecker ggbecker added this to the 0.1.80 milestone Jan 8, 2026
@Mab879 Mab879 self-assigned this Jan 8, 2026
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We change want to change the name to be unique.

with:
github-token: ${{ secrets.GITHUB_TOKEN }}
run-id: ${{ github.event.workflow_run.id }}
name: pr-info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same name as ATEX, I think we might run into issues here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, I also had the same doubt, but apparently the github workflow knows how to distinguish which artifact to download by using the run-id attribute, which is somehow described here: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#using-data-from-the-triggering-workflow

it knows from which workflow triggered the workflow_run and thus knows which artifact to download. That was my assumption. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and see.

@Mab879 Mab879 merged commit 268171c into ComplianceAsCode:master Jan 8, 2026
140 of 142 checks passed
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

ATEX Test Results

Test artifacts have been submitted to Testing Farm.

Results: View Test Results
Workflow Run: View Workflow Details

This comment was automatically generated by the ATEX workflow.

@ggbecker
Copy link
Member Author

ggbecker commented Jan 9, 2026

@Mab879 it seems that my changes worked but for some reason the artifacts with the head sha didn't work, see: https://github.com/ComplianceAsCode/content/actions/runs/20835543123/job/59859380718

we probably just need to remove the head sha from the artifact id and it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compare datastream workflow does not find the forking point

2 participants