Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate CPE check ids for derivative products. #6447

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

ggbecker
Copy link
Member

@ggbecker ggbecker commented Dec 2, 2020

Description:

  • Translate CPE check ids for derivative products.

Rationale:

@ggbecker ggbecker added bugfix Fixes to reported bugs. Python labels Dec 2, 2020
@ggbecker ggbecker added this to the 0.1.54 milestone Dec 2, 2020
@pep8speaks
Copy link

Hello @ggbecker! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 115:100: E501 line too long (126 > 99 characters)

Line 52:100: E501 line too long (107 > 99 characters)

@openscap-ci
Copy link
Collaborator

Changes identified:
Others:
 Changes in Python files.

Show details

Others:
 Python abstract syntax tree change found in build-scripts/enable_derivatives.py.
 Python abstract syntax tree change found in ssg/build_derivatives.py.

Recommended tests to execute:
 (cd build && cmake ../ && ctest -j4)

@Chalmiller
Copy link

Just tested the above code changes and they appear to have fixed the bug. Thank you again @ggbecker!

@redhatrises redhatrises merged commit 3547675 into ComplianceAsCode:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CentOS8 derivative product returning 'not applicable' result for every rule
5 participants