Bug 1857179 - Improved ansible fix for banner files. Replace files on…

[marcusburghardt]

Description:

This patch fix the Bug 1857179 - https://bugzilla.redhat.com/show_bug.cgi?id=1857179
The files / etc / issue and / etc / motd are replaced by the Ansible playbook, even if they are already correct, impacting the efficiency and integrity of the files once a new inode is created.
This patch improves the playbook using the copy module, which ensures that the file is only updated if the current content is different from the desired content.

Rationale:

This patch achieve the same goal with less code and more efficiency.
The copy module is part of ansible-base and included in all Ansible installations.

[openshift-ci]

Hi @marcusburghardt. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jan-cerny]

@marcusburghardt Please rebase and remove the "merge" commits from this PR.

[jan-cerny]

Another good idea is to create a feature branch in your repository instead of using master.

[yuumasato]

Thanks!