Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #8482

Merged
merged 3 commits into from
May 6, 2022
Merged

Add CODEOWNERS #8482

merged 3 commits into from
May 6, 2022

Conversation

jan-cerny
Copy link
Collaborator

Code owners are automatically requested for review when someone opens a
pull request that modifies code that they own. Optionally, the
repository can be configured to require an approval from a code owner
before merging a PR that modifies code that they own.

See:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Related to #8359

Code owners are automatically requested for review when someone opens a
pull request that modifies code that they own. Optionally, the
repository can be configured to require an approval from a code owner
before merging a PR that modifies code that they own.

See:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

CODEOWNERS Outdated
Comment on lines 7 to 8
/products/rhel*/profiles/ @dahaic @evgenyz @ggbecker @jan-cerny @Mab879 @marcusburghardt @matejak @matusmarhefka @mildas @vojtapolasek @yuumasato
/controls/cis_rhel7.yml @dahaic @evgenyz @ggbecker @jan-cerny @Mab879 @marcusburghardt @matejak @matusmarhefka @mildas @vojtapolasek @yuumasato
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matejak GitHub supports using teams in the CODEOWNERS file. It can be useful to create a "Red Hat Employees" team and use the team instead of listing the people repeatedly. I can't setup that because I'm not an admin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-cerny I have created a "Red Hatters" team.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

@jan-cerny
Copy link
Collaborator Author

Would we like to have code owners specified also for example for build system and build scripts?

@Mab879
Copy link
Member

Mab879 commented Apr 4, 2022

I think code owners for the build system, build scripts, utilities would be a good idea.

@jan-cerny
Copy link
Collaborator Author

Actually, in the related PR #8359 where we try to define the responsibilities its already described that CODEOWNERS will be used for:

  • Products
  • Product Specific Profiles
  • Build system
  • Shared Resources
  • Tests

Now the problem is who will be the owners of these modules ... For example who will own build system. The people that contributed to build system? People that had at least 6 PRs to build system? QE? All Red Hatters?

@jan-cerny
Copy link
Collaborator Author

I have changed the file to use the @ComplianceAsCode/red-hatters team, but GH shows an error that the team needs to have write rights.

@Mab879
Copy link
Member

Mab879 commented Apr 5, 2022

@jan-cerny I have given the team write access.

@Mab879
Copy link
Member

Mab879 commented Apr 6, 2022

Actually, in the related PR #8359 where we try to define the responsibilities its already described that CODEOWNERS will be used for:

* Products

* Product Specific Profiles

* Build system

* Shared Resources

* Tests

Now the problem is who will be the owners of these modules ... For example who will own build system. The people that contributed to build system? People that had at least 6 PRs to build system? QE? All Red Hatters?

Do we want to start with just products if we don't have good answers to those questions?

@jan-cerny
Copy link
Collaborator Author

We can, it would be a good start - we would merge this PR and then we can gradually add new restriction as you go,

@matejak Do you have any opinion on CODEOWNERS and current proposal? It's related to your effort of traffic rights.

@matejak matejak self-assigned this Apr 25, 2022
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can be done to move this forward? Now that we have this file listed in our government we should get this merged.

CODEOWNERS Outdated Show resolved Hide resolved
@matejak matejak added this to the 0.1.62 milestone May 4, 2022
@Mab879 Mab879 self-assigned this May 5, 2022
@Mab879
Copy link
Member

Mab879 commented May 5, 2022

@jan-cerny Can you mark this as ready to review?

@matejak
Copy link
Member

matejak commented May 6, 2022

@matejak Do you have any opinion on CODEOWNERS and current proposal? It's related to your effort of traffic rights.

I couldn't agree more, let's merge this and then add more lines gradually.

@jan-cerny
Copy link
Collaborator Author

Yes, then we can stop being a draft and merge this.

@jan-cerny jan-cerny marked this pull request as ready for review May 6, 2022 08:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label May 6, 2022
@matejak matejak merged commit 75672cf into ComplianceAsCode:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants