-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CODEOWNERS #8482
Add CODEOWNERS #8482
Conversation
Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. Optionally, the repository can be configured to require an approval from a code owner before merging a PR that modifies code that they own. See: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Skipping CI for Draft Pull Request. |
CODEOWNERS
Outdated
/products/rhel*/profiles/ @dahaic @evgenyz @ggbecker @jan-cerny @Mab879 @marcusburghardt @matejak @matusmarhefka @mildas @vojtapolasek @yuumasato | ||
/controls/cis_rhel7.yml @dahaic @evgenyz @ggbecker @jan-cerny @Mab879 @marcusburghardt @matejak @matusmarhefka @mildas @vojtapolasek @yuumasato |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matejak GitHub supports using teams in the CODEOWNERS file. It can be useful to create a "Red Hat Employees" team and use the team instead of listing the people repeatedly. I can't setup that because I'm not an admin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jan-cerny I have created a "Red Hatters" team.
Would we like to have code owners specified also for example for build system and build scripts? |
I think code owners for the build system, build scripts, utilities would be a good idea. |
Actually, in the related PR #8359 where we try to define the responsibilities its already described that CODEOWNERS will be used for:
Now the problem is who will be the owners of these modules ... For example who will own build system. The people that contributed to build system? People that had at least 6 PRs to build system? QE? All Red Hatters? |
I have changed the file to use the @ComplianceAsCode/red-hatters team, but GH shows an error that the team needs to have write rights. |
@jan-cerny I have given the team write access. |
Do we want to start with just products if we don't have good answers to those questions? |
We can, it would be a good start - we would merge this PR and then we can gradually add new restriction as you go, @matejak Do you have any opinion on CODEOWNERS and current proposal? It's related to your effort of traffic rights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What can be done to move this forward? Now that we have this file listed in our government we should get this merged.
@jan-cerny Can you mark this as ready to review? |
I couldn't agree more, let's merge this and then add more lines gradually. |
Yes, then we can stop being a draft and merge this. |
Code owners are automatically requested for review when someone opens a
pull request that modifies code that they own. Optionally, the
repository can be configured to require an approval from a code owner
before merging a PR that modifies code that they own.
See:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Related to #8359