-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sysctl OVAL 5.10 build #9311
Conversation
5390428
to
f08f076
Compare
This PR appears to only fix the build for RHEL 8; this helps but doesn't appear to fix the complete OVAL 5.10 build. |
All right, I'm going to check on other distributions as well. Thanks for the review. |
f08f076
to
19d5056
Compare
I have simplified the PR and compared with previous 5.10 criteria and it should match correctly what is expected to be present in OVAL5.10. The 5.10 sanity build now includes all rhel versions. |
Code Climate has analyzed commit 19d5056 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 42.7% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ggbecker: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description: