Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5.10 OVAL validation of core_pattern_empty_string rule #9420

Merged

Conversation

ggbecker
Copy link
Member

Description:

  • Fix 5.10 OVAL validation of core_pattern_empty_string rule.

Rationale:

@ggbecker ggbecker added bugfix Fixes to reported bugs. OVAL OVAL update. Related to the systems assessments. labels Aug 29, 2022
@ggbecker ggbecker added this to the 0.1.64 milestone Aug 29, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@ggbecker ggbecker force-pushed the fix-corepattern-empty-string-5.10 branch from a9bcfa5 to d3b7eab Compare August 29, 2022 11:28
@codeclimate
Copy link

codeclimate bot commented Aug 29, 2022

Code Climate has analyzed commit d3b7eab and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.5% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes ssg-rhel9-oval.xml in the 5.10 version valid again for me!

@jan-cerny jan-cerny self-assigned this Aug 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2022

@ggbecker: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-e8 d3b7eab link true /test e2e-aws-rhcos4-e8
ci/prow/e2e-aws-rhcos4-moderate d3b7eab link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-high d3b7eab link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jan-cerny jan-cerny merged commit 871397e into ComplianceAsCode:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. OVAL OVAL update. Related to the systems assessments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants