Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new rule package_tcp_wrappers_removed #9981

Merged

Conversation

rumch-se
Copy link
Contributor

Description:

  • _A new rule as a part of CIS profile for SLE 12/SLE 15 _

Rationale:

  • The rule supports CIS requirement 2.1.1 Ensure xinetd is not installed (Automated)

@rumch-se rumch-se requested a review from a team as a code owner December 16, 2022 07:58
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2022

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Dec 24, 2022
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts and respond to the instances of xinetd in the new rule.

@Mab879 Mab879 added New Rule Issues or pull requests related to new Rules. SLES SUSE Linux Enterprise Server product related. CIS CIS Benchmark related. labels Jan 4, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 4, 2023
@Mab879 Mab879 self-assigned this Jan 6, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Jan 10, 2023
@rumch-se
Copy link
Contributor Author

Hello @Mab879
I have done rebase. Because tcpd and xinetd are connected, I have tried to provide more details why we have to remove tcpd after the removal of xinetd. CIS covers only the removal of xinetd.
Have a nice day
Rumen

@codeclimate
Copy link

codeclimate bot commented Jan 10, 2023

Code Climate has analyzed commit 1027a1d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.9% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@Mab879
Copy link
Member

Mab879 commented Jan 10, 2023

Automatus failures are expected due to the prodtype.

@Mab879 Mab879 merged commit 1249c5a into ComplianceAsCode:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants