Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule for no .forward files #9990

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Add rule for no .forward files #9990

merged 6 commits into from
Jan 10, 2023

Conversation

teacup-on-rockingchair
Copy link
Contributor

Description:

  • Add implementation of no_forward_files rule

Rationale:

  • Add rule to Ensure no users have .forward files together with oval check and couple tests
  • Assign CCE SLE ids for no_forward_files rule
  • Add no_forward_files rule to CIS SLE profiles

Review Hints:

  • No remediation was added, since it might delete sensitive information and also the CIS benchmark seems to recommend it to go without automatic remediation

@teacup-on-rockingchair teacup-on-rockingchair requested a review from a team as a code owner December 18, 2022 08:13
@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2022

Hi @teacup-on-rockingchair. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 18, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@teacup-on-rockingchair
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2022

@teacup-on-rockingchair: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anivan-suse anivan-suse added the ok-to-test Used by openshift-ci bot. label Dec 21, 2022
@Mab879
Copy link
Member

Mab879 commented Jan 3, 2023

/ok-to-test

@openshift-ci openshift-ci bot removed the needs-ok-to-test Used by openshift-ci bot. label Jan 3, 2023
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. New Rule Issues or pull requests related to new Rules. labels Jan 3, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 3, 2023
@Mab879 Mab879 self-assigned this Jan 5, 2023
@teacup-on-rockingchair
Fixes for review notes
478f10d 
- Thanks to @Mab879 for the review notes
- Fixed copy-paste mistake used .netrc instead of .forward in oval rule
- Make the regex for matching .forward file names unambigious
- Add prodtype to be only sle12 and sle15, although it should work also on rhel,ol and similar
@codeclimate
Copy link

codeclimate bot commented Jan 8, 2023

Code Climate has analyzed commit 478f10d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.9% (0.1% change).

View more on Code Climate.

Mab879
Mab879 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@Mab879
Copy link
Member

Mab879 commented Jan 10, 2023

Automatus tests pass locally.

@Mab879 Mab879 merged commit 32548b0 into ComplianceAsCode:master Jan 10, 2023
@teacup-on-rockingchair teacup-on-rockingchair mentioned this pull request Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
New Rule Issues or pull requests related to new Rules. ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Milestone
0.1.66
Development

Successfully merging this pull request may close these issues.
3 participants
@teacup-on-rockingchair @Mab879 @anivan-suse