Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IdP Keycloak deployment #21

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

Vincent056
Copy link
Collaborator

@Vincent056 Vincent056 commented Jan 30, 2022

This commit works in conjunction with ComplianceAsCode/content#8128, the keycloak deployment keeps falling the CI, we are replacing it with Google IDP.

@Vincent056 Vincent056 force-pushed the idp branch 3 times, most recently from 02d40db to 516d2fa Compare January 30, 2022 19:38
@Vincent056
Copy link
Collaborator Author

/test e2e-aws-rhcos4-moderate

@Vincent056 Vincent056 force-pushed the idp branch 2 times, most recently from a148ddf to bbf4ceb Compare January 30, 2022 23:24
@Vincent056 Vincent056 changed the title Fix IdP Keycloak WIP: Fix IdP Keycloak Jan 31, 2022
@Vincent056
Copy link
Collaborator Author

Vincent056 commented Jan 31, 2022

There are still issues with KeyCloak IDP, I added this PR ComplianceAsCode/content#8128. Maybe we can switch to using Google IdP instead?

@Vincent056
Copy link
Collaborator Author

/retest

@Vincent056 Vincent056 changed the title WIP: Fix IdP Keycloak Remove IdP Keycloak deployment Feb 2, 2022
This commit works in conjunction with ComplianceAsCode/content#8128, the keycloak deployment keeps falling the CI, we are replacing it with Google IDP.
@jhrozek
Copy link
Collaborator

jhrozek commented Feb 3, 2022

The pci-dss failure was a cluster setup error, the moderate one looks legit, though:

     helpers.go:805: Result - Name: e2e-moderate-api-server-no-adm-ctrl-plugins-disabled - Status: FAIL - Severity: medium
    helpers.go:808: E2E-FAILURE: The expected result for the api_server_no_adm_ctrl_plugins_disabled rule didn't match. Expected 'PASS', Got 'FAIL' 

@Vincent056 I thought we fixed this some time ago, does this PR maybe just need rebasing?

@jhrozek
Copy link
Collaborator

jhrozek commented Feb 3, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

@Vincent056: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-moderate fb0024f link true /test e2e-aws-ocp4-moderate
ci/prow/e2e-aws-ocp4-cis fb0024f link true /test e2e-aws-ocp4-cis

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jhrozek
Copy link
Collaborator

jhrozek commented Feb 3, 2022

hmm, still failing, but at least manually it seems that the rule works fine

@Vincent056
Copy link
Collaborator Author

Vincent056 commented Feb 3, 2022

This one will not pass, because the rule adding google IDP is not merged yet, we can merge this PR first and test it here: ComplianceAsCode/content#8128 @jhrozek

@jhrozek
Copy link
Collaborator

jhrozek commented Feb 9, 2022

Together with using google IDP, this should help.

@jhrozek jhrozek merged commit 0ec3dce into ComplianceAsCode:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants