-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IdP Keycloak deployment #21
Conversation
02d40db
to
516d2fa
Compare
/test e2e-aws-rhcos4-moderate |
a148ddf
to
bbf4ceb
Compare
There are still issues with KeyCloak IDP, I added this PR ComplianceAsCode/content#8128. Maybe we can switch to using Google IdP instead? |
/retest |
This commit works in conjunction with ComplianceAsCode/content#8128, the keycloak deployment keeps falling the CI, we are replacing it with Google IDP.
The
@Vincent056 I thought we fixed this some time ago, does this PR maybe just need rebasing? |
/retest |
@Vincent056: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
hmm, still failing, but at least manually it seems that the rule works fine |
This one will not pass, because the rule adding google IDP is not merged yet, we can merge this PR first and test it here: ComplianceAsCode/content#8128 @jhrozek |
Together with using google IDP, this should help. |
This commit works in conjunction with ComplianceAsCode/content#8128, the keycloak deployment keeps falling the CI, we are replacing it with Google IDP.