Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Quay compliance-operator/compliance-operator-content for images #27

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

rhmdnd
Copy link
Collaborator

@rhmdnd rhmdnd commented Apr 22, 2022

The previous home for compliance content images hadn't been updated in
months, causing CI to fail with issues that had already been fixed.

This commit updates the content image location to use
compliance-operator/compliance-operator-content, which contains updated
images:

https://quay.io/repository/compliance-operator/compliance-operator-content

The previous home for compliance content images hadn't been updated in
months, causing CI to fail with issues that had already been fixed.

This commit updates the content image location to use
compliance-operator/compliance-operator-content, which contains updated
images:

https://quay.io/repository/compliance-operator/compliance-operator-content
Copy link
Collaborator

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 22, 2022

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-cis 2e585a0 link true /test e2e-aws-ocp4-cis
ci/prow/e2e-aws-ocp4-moderate 2e585a0 link true /test e2e-aws-ocp4-moderate
ci/prow/e2e-aws-rhcos4-moderate 2e585a0 link true /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -2,7 +2,7 @@ PROFILE?=
# Defines the product that the test aims to test
# Since we already have test for RHCOS4, this is the default for now.
PRODUCT?=rhcos4
CONTENT_IMAGE?=quay.io/complianceascode/ocp4:latest
CONTENT_IMAGE?=quay.io/compliance-operator/compliance-operator-content:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding docs on how this is built and where it comes from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - good call. I already have a patch up that adds a README.md

#25

Can I stack it on top of that? I already proposed a patch to openshift/compliance-operator that describes the container images.

openshift/compliance-operator#824

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those! As a last piece... is there automation in place to build the ocp4 container tag? or is that being done manually?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on the ocp4 container tag bit? We're tagging container images with the git short SHA, branch, and latest (when applicable).

Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhrozek
Copy link
Collaborator

jhrozek commented Apr 29, 2022

Merging with administrative privs, looks like as usual we need to sync commit the content with the suite.

@jhrozek jhrozek merged commit 9a2524b into ComplianceAsCode:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants