-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Quay compliance-operator/compliance-operator-content for images #27
Use Quay compliance-operator/compliance-operator-content for images #27
Conversation
The previous home for compliance content images hadn't been updated in months, causing CI to fail with issues that had already been fixed. This commit updates the content image location to use compliance-operator/compliance-operator-content, which contains updated images: https://quay.io/repository/compliance-operator/compliance-operator-content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -2,7 +2,7 @@ PROFILE?= | |||
# Defines the product that the test aims to test | |||
# Since we already have test for RHCOS4, this is the default for now. | |||
PRODUCT?=rhcos4 | |||
CONTENT_IMAGE?=quay.io/complianceascode/ocp4:latest | |||
CONTENT_IMAGE?=quay.io/compliance-operator/compliance-operator-content:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding docs on how this is built and where it comes from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - good call. I already have a patch up that adds a README.md
Can I stack it on top of that? I already proposed a patch to openshift/compliance-operator that describes the container images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding those! As a last piece... is there automation in place to build the ocp4
container tag? or is that being done manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on the ocp4
container tag bit? We're tagging container images with the git short SHA, branch, and latest
(when applicable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging with administrative privs, looks like as usual we need to sync commit the content with the suite. |
The previous home for compliance content images hadn't been updated in
months, causing CI to fail with issues that had already been fixed.
This commit updates the content image location to use
compliance-operator/compliance-operator-content, which contains updated
images:
https://quay.io/repository/compliance-operator/compliance-operator-content