Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcvm: avoid String allocations when opening an IBC channel #3685

Merged
merged 1 commit into from
Jun 13, 2023
Merged

xcvm: avoid String allocations when opening an IBC channel #3685

merged 1 commit into from
Jun 13, 2023

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Jun 12, 2023

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • I have linked Zenhub/Github or any other reference item if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • I waited and did best effort for pr-workflow-check / draft-release-check to finish with success(green check mark) with my changes
  • I have added at least one reviewer in reviewers list
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production

@mina86 mina86 added this pull request to the merge queue Jun 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2023
@blasrodri blasrodri added this pull request to the merge queue Jun 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2023
@mina86
Copy link
Contributor Author

mina86 commented Jun 13, 2023

Hmm…

/home/actions-runner/actions-runner/_work/_actions/cachix/cachix-action/586bf280495080c5a6d4868237ad28a860e4b309/dist/main/push-paths.sh cachix  composable-community
  /home/actions-runner/actions-runner/_work/_actions/cachix/cachix-action/586bf280495080c5a6d4868237ad28a860e4b309/dist/main/push-paths.sh: line 14: cachix: command not found
  Error: Action failed with error: Error: The process '/home/actions-runner/actions-runner/_work/_actions/cachix/cachix-action/586bf280495080c5a6d4868237ad28a860e4b309/dist/main/push-paths.sh' failed with exit code 127

No idea what cachix is. Will try to figure it out tomorrow.

@dzmitry-lahoda
Copy link
Contributor

yeah, i just down runners. i though people sleep :)

@dzmitry-lahoda
Copy link
Contributor

please rebase on main

@mina86 mina86 added this pull request to the merge queue Jun 13, 2023
@dzmitry-lahoda dzmitry-lahoda self-requested a review June 13, 2023 10:12
Merged via the queue into ComposableFi:main with commit 4c3676c Jun 13, 2023
@mina86 mina86 deleted the a branch June 13, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants